-
Notifications
You must be signed in to change notification settings - Fork 21
Workshop infra #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workshop infra #285
Conversation
This commit refactors the software list to correctly filter based on context, ensuring accurate display on the main software page and sub-pages.
…ltering refactor: software-list.html: Improve software list filtering
This commit updates Matei Stan's contributor information with his LinkedIn profile and adds his photo. Also includes his photo for the student talks section. Fixes minor issues with speaker bio and references in student talk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent changes @neural-loop! Thank you very much :)
I like how we get all the contributor pages in there, leveraging the strenght of Hugo. Nice.
One comment: are you sure we should deploy the docs when the student-talks branch gets pushed?
@@ -2,7 +2,7 @@ name: Deploy Hugo site to Pages | |||
|
|||
on: | |||
push: | |||
branches: ["main", "cache-images"] | |||
branches: ["main", "student-talk"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this deploy the student-talk branch? Is that what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I could have pruned that bit, but was being lazy. Basically the only place where I'm pushing student-talk branch was to my github, and this was to trigger the build there. I'll update this to a trigger in the commit message (eventually)
It wouldn't build over our production as new 'branches' have to additionally be configured in the github config (at least that has been my experience)
No description provided.