Skip to content

Workshop infra #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neural-loop
Copy link
Member

No description provided.

@neural-loop neural-loop requested a review from Jegp July 12, 2025 00:24
Copy link
Member

@Jegp Jegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent changes @neural-loop! Thank you very much :)

I like how we get all the contributor pages in there, leveraging the strenght of Hugo. Nice.

One comment: are you sure we should deploy the docs when the student-talks branch gets pushed?

@@ -2,7 +2,7 @@ name: Deploy Hugo site to Pages

on:
push:
branches: ["main", "cache-images"]
branches: ["main", "student-talk"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this deploy the student-talk branch? Is that what we want?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I could have pruned that bit, but was being lazy. Basically the only place where I'm pushing student-talk branch was to my github, and this was to trigger the build there. I'll update this to a trigger in the commit message (eventually)

It wouldn't build over our production as new 'branches' have to additionally be configured in the github config (at least that has been my experience)

@neural-loop neural-loop merged commit d05f3fd into open-neuromorphic:workshop-infra Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants